Open
Conversation
the icon is not showing because it was only added to font-awesome @ 5.0.0 Upgrading font-awesome is something I don't feel comfortable doing, primarily because I don't have a fully working local env to test out the changes to the website. (https://github.com/softwarecrafters/website#-contributing-to-the-website is still "TBD")
Contributor
Author
|
ah, cool, I just noticed there's a deploy preview here ! nicely done!! |
Contributor
Author
|
I just noticed the discord invite is personalized ("yorgos invites you") and I was not aiming for that. I'll look into whether a vanilla one is possible. |
Contributor
Author
|
I wasn't able to find an easy way of the personalized invite: https://support.discord.com/hc/en-us/articles/208866998-Invites-101 I don't mind if we keep that - I just don't like that it is so person-centric... Thoughts / ideas are more than welcome! |
Contributor
|
Regarding font awesome: please use an image for the logo, i won't have time soon to upgrade font awesome, i vaguely remember the license changing so it might not be trivial. |
discord icon is only available on font-awesome 5.0.0+
Contributor
Author
|
@rradczewski should be all set now |
this one will only grant temporary access. If folks don't accept the code of conduct (which happens through a discord role assignment, powered by carl-bot), they won't stay on the server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers:
the discord icon is not showing because it was only added to font-awesome @ 5.0.0
Upgrading font-awesome is something I don't feel comfortable doing, primarily because I don't have a fully working local env to test out the changes to the website. (https://github.com/softwarecrafters/website#-contributing-to-the-website is still "TBD")