Fixes issue #8 with GCC/Clang-specific compiler intrinsics with MSVC/MS Windows #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws/MSVC Installing searcharray in Visual Studio Code on MS Windows fails because the MSVC compiler does not support the following GCC/Clang-specific compiler intrinsics: __builtin_popcountll, __builtin_ctzll, __builtin_clzll The issue can be solved by either installing GCC/Clang or by conditionally replacing __builtin_popcountll, __builtin_ctzll, __builtin_clzll with MSVC equivalents in popcount.pyx, roaringish_ops.pyx and spans.pyx
Owner
|
Nice! This is awesome. Thanks @wolfgarbe |
Owner
|
Tested your PR on OSX and all tests pass 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing searcharray in Visual Studio Code on MS Windows fails because the MSVC compiler does not support the following GCC/Clang-specific compiler intrinsics: __builtin_popcountll, __builtin_ctzll, __builtin_clzll
The pull request solves the issue by conditionally replacing __builtin_popcountll, __builtin_ctzll, __builtin_clzll with MSVC equivalents in popcount.pyx, roaringish_ops.pyx and spans.pyx
It has been tested both on MS Windows 11 and WSL:Ubuntu-24.04