Skip to content

SAM-EM Carbon Price Support#142

Open
softwareengineerprogrammer wants to merge 1 commit intomainfrom
sam-em-carbon-revenue
Open

SAM-EM Carbon Price Support#142
softwareengineerprogrammer wants to merge 1 commit intomainfrom
sam-em-carbon-revenue

Conversation

@softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Mar 22, 2026

Description

  1. Support for carbon price calculations for SAM Economic Models (SAM Economic Models do not calculate carbon revenue NatLabRockies/GEOPHIRES-X#458)
  2. Fix support for suffixed currency conversions e.g. USD/tonneUSD/lb

Testing & Verification

  1. Unit tests added:
    1. example_SAM-single-owner-PPA-6_carbon-revenue
  2. Unit tests updated: Describe existing unit tests that were updated, if any.
  3. Manual testing: Describe any additional manual testing steps that were performed, such as running the change on a pre-existing data set you own.

TODO

  1. Add cash flow line items (price, revenue, lbs, etc.)
  2. Documentation
    1. SAM-EM docs
      1. https://github.com/NatLabRockies/GEOPHIRES-X/blob/d9d40b9c76a95466ba82dda9e25501f75ec4308b/docs/SAM-Economic-Models.md?plain=1#L55
    2. example_SAM-single-owner-PPA-6_carbon-revenue description
  3. README example list entry
  4. Trim example_SAM-single-owner-PPA-6_carbon-revenue parameter comments
  5. Minor version bump
    1. potential change in SAM-EM results due to carbon calculations
    2. suffixed currency conversion fix
  6. USD/tonne unit fix
  7. CARBON REVENUE PROFILE in result

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. Add a CHANGELOG entry (example). RST Template:
M.m.P: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/vM.m.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
M.m.p: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-reviewed in #142

@softwareengineerprogrammer softwareengineerprogrammer added bug Something isn't working enhancement New feature or request labels Mar 22, 2026
add_on_profit_per_year = np.sum(model.addeconomics.AddOnProfitGainedPerYear.quantity().to('USD/yr').magnitude)
add_on_profit_series = [add_on_profit_per_year] * model.surfaceplant.plant_lifetime.value
ret['cp_capacity_payment_amount'] = add_on_profit_series
if econ.DoAddOnCalculations.value or econ.DoCarbonCalculations.value:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break into separate capacity payment method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant