Add scalafmtAll hook#15
Merged
Merged
Conversation
add scalafmtAll hook
add function to stage modified files
Contributor
Author
|
Hello @adamw, any chance to get this merged? |
adamw
reviewed
Mar 19, 2025
| - `sbt-unused-imports` - as above, but also adds the "unused imports" warning. | ||
| - `sbt-scalafmt` - runs `scalafmtCheckAll`. | ||
| - `sbt-wartremover` - runs the wartremover plugin. | ||
| - `sbt-scalafmt-apply` - runs `scalafmtAll`. |
Member
There was a problem hiding this comment.
shouldn't we add some more information here, on how this differs from sbt-scalafmt?
Contributor
Author
There was a problem hiding this comment.
Sure. Just done, keeping the coincise style of the other commands. Let me know if looks good or you want to add some more information
Member
|
@gumaz sure! sorry, for some reason I didn't have notifications turned on for this repo |
clarify the effect of sbt-scalafmt-apply
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Git pre-commit hook is failing when sbt scalafmtAll modifies files, even though the command itself exits successfully (exit code 0). This likely happens because git expects the working directory to be clean after the pre-commit hook runs. If scalafmtAll modifies any files, git sees uncommitted changes and fails the commit.
So I added a function to also run
git add -uto stage tracked files that may have been modified by the formatter.Test