MPT-19908: add /integration/installations service

[albertsola]

Summary

Implements the /public/v1/integration/installations endpoint group as part of MPT-13310.

Changes

• mpt_api_client/resources/integration/installations.py — InstallationsService / AsyncInstallationsService
• mpt_api_client/resources/integration/mixins/installation_mixin.py — lifecycle actions: invite, install, uninstall, expire
• Updated integration.py to expose installations property
• Unit tests: tests/unit/resources/integration/test_installations.py + test_installation_mixin.py
• E2e tests: tests/e2e/integration/installations/

Depends on

#277 (MPT-19892 — rename extensibility → integration)

⚠️ Draft — targets MPT-19892/e2e-extension-base-service until PR #277 merges.

Closes MPT-19908

• Add InstallationsService and AsyncInstallationsService for /public/v1/integration/installations
• Introduce Installation model (id, name, revision, account, extension, status, configuration, invitation, modules, terms, audit)
• Add InstallationMixin and AsyncInstallationMixin with lifecycle actions: redeem, renew, token, token_for_account
• Expose installations property on Integration and AsyncIntegration
• Add unit tests for installations service, installation mixin, and Integration/AsyncIntegration properties
• Add e2e tests and fixtures for installations (sync and async) including create/get/filter/redeem/delete flows; some renewal/token tests are present but skipped
• Add helper for decoding invitation payloads used by e2e tests
• Update e2e_config.test.json: set integration.extension.id = EXT-6587-4477 and add integration.installation.id = EXI-0022-3978-5547
• Update e2e fixtures to source extension clients from mpt_vendor and unskip several extension e2e tests (create/update/delete/download_icon)
• Update pyproject.toml flake8 per-file-ignores for new e2e installation tests
• Draft PR depends on PR MPT-19892: add E2E tests for Extension base service - Includes renaming from extensibility -> integrations #277 (MPT-19892 — rename extensibility → integration); currently targets MPT-19892/e2e-extension-base-service until merged

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds an "installations" integration resource: new Installation model, sync/async service classes, installation mixins (redeem/renew/token/token_for_account), integration wiring, unit and E2E tests, Flake8 ignore entries, and small E2E fixture/test and config updates.

Changes

Installation Resource and Tests

Layer / File(s)	Summary
Data Shape mpt_api_client/resources/integration/installations.py	Adds Installation model with optional fields for metadata, references, lifecycle state, and related data.
Core Mixins mpt_api_client/resources/integration/mixins/installation_mixin.py	Adds InstallationMixin and AsyncInstallationMixin with redeem, renew, token, and token_for_account methods that POST to per-action endpoints; renew accepts optional request body; token_for_account can include account.id query param.
Service Config & Wiring mpt_api_client/resources/integration/installations.py	Adds InstallationsServiceConfig (/public/v1/integration/installations, model Installation, collection key data) and InstallationsService/AsyncInstallationsService composed from mixins, managed-resource, and collection behaviors.
Integration Surface mpt_api_client/resources/integration/integration.py	Imports and exposes Integration.installations and AsyncIntegration.installations properties returning the respective service instances using the parent's HTTP client.
Module Exports mpt_api_client/resources/integration/mixins/__init__.py	Exports InstallationMixin and AsyncInstallationMixin from the mixins package.
Unit Tests: mixins & service tests/unit/resources/integration/mixins/test_installation_mixin.py, tests/unit/resources/integration/test_installations.py, tests/unit/resources/integration/test_integration.py	Adds tests that mock POSTs to validate mixin behaviors (redeem/renew/token/token_for_account), service composition and available methods, Installation model parsing for primitives and nested BaseModel fields, and Integration property coverage for installations.
E2E Fixtures for Installations tests/e2e/integration/installations/conftest.py	Adds sync/async installations_service fixtures, session-scoped installation_id from e2e_config, installation_data payload, and created_installation/async_created_installation create-teardown fixtures with best-effort delete handling.
E2E Tests for Installations tests/e2e/integration/installations/test_sync_installations.py, tests/e2e/integration/installations/test_async_installations.py	Adds flaky-marked E2E tests for get, filter, create/redeem/delete flows; some token/renew tests are skipped.
E2E Extensions Test Adjustments tests/e2e/integration/extensions/conftest.py, tests/e2e/integration/extensions/test_sync_extensions.py, tests/e2e/integration/extensions/test_async_extensions.py	Switches extension fixtures to accept mpt_vendor/async_mpt_vendor and removes pytest.mark.skip from several extension create/update/delete/download tests.
Config e2e_config.test.json	Updates integration.extension.id value and adds new integration.installation.id key.
Lint config pyproject.toml	Adds Flake8 per-file-ignores for tests/e2e/integration/installations/*.py (WPS453 WPS202).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

• softwareone-platform/mpt-api-python-client#285: Also modifies mpt_api_client/resources/integration/mixins/__init__.py to extend module exports with newly added mixins.
• softwareone-platform/mpt-api-python-client#277: Previously changed the Integration/AsyncIntegration surface that this PR extends by adding the installations subservice.
• softwareone-platform/mpt-api-python-client#286: Overlaps on e2e_config.test.json changes to integration.extension.id and related test configuration.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Jira Issue Key In Title	✅ Passed	PR title contains exactly one Jira issue key in the correct format: MPT-19908
Test Coverage Required	✅ Passed	PR modifies 6 code files but includes 11 test files with changes covering unit tests, E2E tests, and test fixtures. Test coverage is included.
Single Commit Required	✅ Passed	The PR contains exactly 1 commit: "5be5e0c MPT-19908: add e2e tests for /public/v1/integration/installations". No squashing is required.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

tests/unit/resources/integration/mixins/test_installation_mixin.py (1)

46-66: Consider adding one case that verifies JSON payload forwarding.

These tests currently validate action routing and response parsing, but not that resource_data is sent through to post(..., json=...). Adding one payload case (sync + async) would close that gap.

Also applies to: 72-91

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/unit/resources/integration/mixins/test_installation_mixin.py` around
lines 46 - 66, Add a test variant that checks the request JSON payload is
forwarded: in the test_post_actions function (and the async counterpart if
present), include a resource_data dict and call getattr(installation_service,
action)(installation_id, resource_data=resource_data) (or await for async), then
assert the mocked respx.post received json==resource_data (e.g., inspect
mock_route.calls[0].request.read() or .json()) and keep existing assertions on
method, call_count, and response parsing to ensure post(..., json=...) is used.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/e2e/integration/extensions/test_async_extensions.py`:
- Around line 9-11: The test file has three consecutive blank lines before the
top-level test function test_create_extension causing ruff format --check to
fail; edit the file to remove one blank line so there are exactly two blank
lines separating top-level definitions (ensure there are two blank lines
immediately before def test_create_extension and no leftover `@pytest.mark.skip`
or stray blank lines).

---

Nitpick comments:
In `@tests/unit/resources/integration/mixins/test_installation_mixin.py`:
- Around line 46-66: Add a test variant that checks the request JSON payload is
forwarded: in the test_post_actions function (and the async counterpart if
present), include a resource_data dict and call getattr(installation_service,
action)(installation_id, resource_data=resource_data) (or await for async), then
assert the mocked respx.post received json==resource_data (e.g., inspect
mock_route.calls[0].request.read() or .json()) and keep existing assertions on
method, call_count, and response parsing to ensure post(..., json=...) is used.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7638d5c8-b871-4f3d-b269-3aec3a657875

📥 Commits

Reviewing files that changed from the base of the PR and between f543c53 and f58b8f7.

📒 Files selected for processing (16)

• e2e_config.test.json
• mpt_api_client/resources/integration/installations.py
• mpt_api_client/resources/integration/integration.py
• mpt_api_client/resources/integration/mixins/__init__.py
• mpt_api_client/resources/integration/mixins/installation_mixin.py
• pyproject.toml
• tests/e2e/integration/extensions/conftest.py
• tests/e2e/integration/extensions/test_async_extensions.py
• tests/e2e/integration/extensions/test_sync_extensions.py
• tests/e2e/integration/installations/__init__.py
• tests/e2e/integration/installations/conftest.py
• tests/e2e/integration/installations/test_async_installations.py
• tests/e2e/integration/installations/test_sync_installations.py
• tests/unit/resources/integration/mixins/test_installation_mixin.py
• tests/unit/resources/integration/test_installations.py
• tests/unit/resources/integration/test_integration.py

💤 Files with no reviewable changes (1)

• tests/e2e/integration/extensions/test_sync_extensions.py

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

🧹 Nitpick comments (1)

tests/unit/resources/integration/mixins/test_installation_mixin.py (1)

146-183: ⚡ Quick win

Add coverage for token_for_account() without account_id.

Current tests validate only the account_id-provided branch. Adding the no-arg path would cover the query_params=None branch and guard endpoint behavior for default account-token retrieval.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/unit/resources/integration/mixins/test_installation_mixin.py` around
lines 146 - 183, Add tests covering the no-argument branch of token_for_account:
create both sync and async variants similar to test_token_for_account and
test_async_token_for_account but call installation_service.token_for_account()
and async_installation_service.token_for_account() with no arguments, set up
respx.post for the same URL without the params argument (so query_params is
None), mock the same httpx.Response payload, and assert mock_route.call_count ==
1 and result.to_dict() equals the expected_response; this ensures the
query_params=None branch is exercised.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/unit/resources/integration/mixins/test_installation_mixin.py`:
- Around line 146-183: Add tests covering the no-argument branch of
token_for_account: create both sync and async variants similar to
test_token_for_account and test_async_token_for_account but call
installation_service.token_for_account() and
async_installation_service.token_for_account() with no arguments, set up
respx.post for the same URL without the params argument (so query_params is
None), mock the same httpx.Response payload, and assert mock_route.call_count ==
1 and result.to_dict() equals the expected_response; this ensures the
query_params=None branch is exercised.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c38a583e-85a1-4a99-b7da-c3478c68984d

📥 Commits

Reviewing files that changed from the base of the PR and between 76009ff and 5be5e0c.

📒 Files selected for processing (14)

• e2e_config.test.json
• mpt_api_client/resources/integration/mixins/installation_mixin.py
• pyproject.toml
• tests/e2e/integration/conftest.py
• tests/e2e/integration/extensions/conftest.py
• tests/e2e/integration/extensions/test_async_extensions.py
• tests/e2e/integration/extensions/test_sync_extensions.py
• tests/e2e/integration/installations/__init__.py
• tests/e2e/integration/installations/conftest.py
• tests/e2e/integration/installations/helper.py
• tests/e2e/integration/installations/test_async_installations.py
• tests/e2e/integration/installations/test_sync_installations.py
• tests/unit/resources/integration/mixins/test_installation_mixin.py
• tests/unit/resources/integration/test_installations.py

💤 Files with no reviewable changes (2)

• tests/e2e/integration/extensions/test_async_extensions.py
• tests/e2e/integration/extensions/test_sync_extensions.py