Improve configurator gemini configure and etcd keys deletion#410
Merged
Improve configurator gemini configure and etcd keys deletion#410
Conversation
ffaraone
requested changes
May 7, 2026
| self.etcd_cl.delete(key) | ||
| except etcd.EtcdKeyNotFound: | ||
| if is_dir: | ||
| self.etcd_cl.delete(key, dir=True, recursive=True) |
Collaborator
There was a problem hiding this comment.
Are we sure both dir and recursive must be passed?
Author
There was a problem hiding this comment.
Yes, at first added only dir=True and it failed.
etcd client library has not the best implementation, if we could switch to etcd3 life would be easier
bdjilka
force-pushed
the
configurator_improvements
branch
from
4a09e50 to
3df7245
Compare
ffaraone
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.