Skip to content

Comments

Feature/308 init with remotes#323

Merged
nheeb merged 7 commits intodevelopfrom
feature/308-init-with-remotes
Apr 23, 2025
Merged

Feature/308 init with remotes#323
nheeb merged 7 commits intodevelopfrom
feature/308-init-with-remotes

Conversation

@nheeb
Copy link
Contributor

@nheeb nheeb commented Feb 28, 2025

The new #308 problems should be fixed.
Closes #308

SKernchen
SKernchen previously approved these changes Mar 17, 2025
Copy link
Contributor

@SKernchen SKernchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

One problem i got is that the authentification with github used the wrong remote url/project.
So my test remote did not have any rights and the other remote got the secrets and permissons.

@SKernchen SKernchen self-requested a review March 17, 2025 12:41
@SKernchen SKernchen dismissed their stale review March 17, 2025 12:41

Found a bug

@SKernchen SKernchen assigned nheeb and unassigned SKernchen Mar 17, 2025
Copy link
Contributor

@zyzzyxdonta zyzzyxdonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and all of the setups I tested worked 👍🏻

@nheeb nheeb merged commit d5f5fcc into develop Apr 23, 2025
5 checks passed
@poikilotherm poikilotherm deleted the feature/308-init-with-remotes branch June 6, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hermes init fails with cryptic error message in non-git directory

3 participants