Merged
Conversation
zyzzyxdonta
requested changes
Apr 28, 2025
zyzzyxdonta
approved these changes
Apr 29, 2025
Contributor
zyzzyxdonta
left a comment
zyzzyxdonta
left a comment
There was a problem hiding this comment.
Makes sense to me 👍🏻
Comment on lines
+184
to
+195
| self.hermes_toml_data = { | ||
| "harvest": { | ||
| "sources": ["cff"] | ||
| }, | ||
| "deposit": { | ||
| "target": "invenio_rdm", | ||
| "invenio_rdm": { | ||
| "site_url": "", | ||
| "access_right": "open" | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This feels like we should use hermes.commands.base._HermesSettings instead. But I don't see how 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins can be installed with init
Closes #328
Related to #298 (plugins don't really want to ask questions yet)