Tests for HermesContext and HermesCache#382
Conversation
led02
left a comment
led02
left a comment
There was a problem hiding this comment.
Nice and well collected test cases, also very pythonic!
See inline comments for minor changes.
| # SPDX-FileCopyrightText: 2022 German Aerospace Center (DLR) | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
I think I added this because REUSE complained.
I agree that empty files have not much originalty in it, so on could argue whether we need this license tag.
However, we should at least be consistent here...
There was a problem hiding this comment.
Yes we can keep it, I think it changed automatically, because of recent open files.
There was a problem hiding this comment.
The FAQs suggest that it's fine to use either the default copyright, or CC0-1.0 for license and NONE for copyright holder. So I think that keeping as is is fine.
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
led02
left a comment
led02
left a comment
There was a problem hiding this comment.
Minor fixes which can be addressed in other referenced issues.
src/hermes/model/context_manager.py
Outdated
| current_step = self._current_step[-1] | ||
| if current_step != step: | ||
| raise ValueError(f"Cannot end step {step} while in {self._current_step[-1]}.") | ||
| self._current_step.pop() |
There was a problem hiding this comment.
Why do you put the "fix" into the comment instead of putting it into the implementation?
The however, the first line will still throw an IndexError for empty lists.
src/hermes/model/context_manager.py
Outdated
|
|
||
|
|
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
3 participants
No description provided.