Rename ts, ep => timestamp, harvester#90
Merged
led02 merged 5 commits into26-implement-processing-stepfrom Jan 11, 2023
Merged
Conversation
jkelling
changed the base branch from
develop
to
26-implement-processing-step
jkelling
force-pushed
the
84-rename-ts-ep-et-al-in-hermes-json-in-hermes-to-better-terms
branch
from
5ff1916 to
2556abe
Compare
Contributor
|
@jkelling I guess the tests should also be adapted, e.g. |
jkelling
force-pushed
the
84-rename-ts-ep-et-al-in-hermes-json-in-hermes-to-better-terms
branch
from
2556abe to
509a063
Compare
sdruskat
reviewed
Jan 11, 2023
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
sdruskat
approved these changes
Jan 11, 2023
Contributor
sdruskat
left a comment
sdruskat
left a comment
There was a problem hiding this comment.
Good to go with the respective comments.
sdruskat
deleted the
84-rename-ts-ep-et-al-in-hermes-json-in-hermes-to-better-terms
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84