Skip to content

Remove experimental quickfix logging #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdruskat merged 6 commits into from
Jan 11, 2023
Merged

Remove experimental quickfix logging #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8de56d
Remove hint logger from configuration
sdruskat Jan 11, 2023
0aa1609
Remove hint logging from git harvester
sdruskat Jan 11, 2023
e236d01
Merge remote-tracking branch 'origin/26-implement-processing-step' in…
sdruskat Jan 11, 2023
a48c0cd
Merge branch '26-implement-processing-step' into 82-remove-quickfix-l…
sdruskat Jan 11, 2023
f185a70
Merge remote-tracking branch 'origin/26-implement-processing-step' in…
sdruskat Jan 11, 2023
4751dda
Merge branch '26-implement-processing-step' into 82-remove-quickfix-l…
sdruskat Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ level = "DEBUG"
filename = "hermes-audit.md"
mode = "w"

[tool.hermes.logging.handlers.hintfile]
class = "logging.FileHandler"
formatter = "plain"
level = "DEBUG"
filename = "quickfix.sh"

[tool.hermes.logging.loggers.cli]
level = "DEBUG"
handlers = ["terminal"]
Expand All @@ -128,11 +122,6 @@ handlers = ["terminal", "logfile"]
level = "DEBUG"
handlers = ["terminal", "auditfile"]

[tool.hermes.logging.loggers.audit.hint]
level = "DEBUG"
propagate = false
handlers = ["terminal", "hintfile"]

[tool.taskipy.tasks]
docs-build = "poetry run sphinx-build -M html docs/source docs/build -W"
docs-clean = "poetry run sphinx-build -M clean docs/source docs/build"
Expand Down
26 changes: 0 additions & 26 deletions src/hermes/commands/harvest/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,32 +234,6 @@ def _audit_authors(authors, audit_log: logging.Logger):
audit_log.info('')
audit_log.info('``` .mailmap')

# Provide some example configuration for the hint log
hint_log = audit_log.parent.getChild('hints')
hint_log.debug("# '.maillog' to resolve git ambiguities.")

unmapped_email = [a for a in unmapped_authors if a.email[1:]]
if unmapped_email:
hint_log.debug('# Mapping of email addresses only. Format (one pair per line):')
hint_log.debug('# <old.email@ddress> <new.email@address>')

for author in unmapped_email:
for email in author.email[1:]:
hint_log.info("<%s> <%s>", str(author.email[0]), str(email))
hint_log.debug('')

unmapped_name = [a for a in unmapped_authors if a.name[1:]]
if unmapped_name:
hint_log.debug('# Mapping of user names. Format (one pair per line):')
hint_log.debug('# Real Name <email@ddress> nickname')
hint_log.debug('# Real Name <email@ddress> Name, Real')

for author in [a for a in unmapped_authors if a.name[1:]]:
for name in author.name[1:]:
hint_log.info('%s <%s> %s', str(author.name[0]), str(author.email[0]), str(name))

hint_log.info('')

audit_log.info('```')


Expand Down