Skip to content

villas: Use Python dictionaries for defining VILLASconfig files#343

Merged
stv0g merged 1 commit into
sogno-platform:masterfrom
stv0g:use-python-dicts-for-villas-interface-config
Mar 27, 2025
Merged

villas: Use Python dictionaries for defining VILLASconfig files#343
stv0g merged 1 commit into
sogno-platform:masterfrom
stv0g:use-python-dicts-for-villas-interface-config

Conversation

@stv0g
Copy link
Copy Markdown
Contributor

@stv0g stv0g commented Mar 25, 2025

No description provided.

Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
@stv0g stv0g requested review from fwege and n-eiling March 25, 2025 02:39
@stv0g stv0g self-assigned this Mar 25, 2025
@stv0g stv0g requested a review from pipeacosta as a code owner March 25, 2025 02:39
@stv0g
Copy link
Copy Markdown
Contributor Author

stv0g commented Mar 25, 2025

@pipeacosta Could you review & approve this change? We need your approval as a code owner.

Thanks :)

@stv0g
Copy link
Copy Markdown
Contributor Author

stv0g commented Mar 26, 2025

Thanks @m-mirz for the approval.

Unfortunately, I can still not merge the PR. Could you check the branch protection settings?
I think having a single code-owner approving should be sufficient for merging?

@m-mirz
Copy link
Copy Markdown
Contributor

m-mirz commented Mar 26, 2025

Thanks @m-mirz for the approval.

Unfortunately, I can still not merge the PR. Could you check the branch protection settings? I think having a single code-owner approving should be sufficient for merging?

I could not merge either. It was blocked by the failing sonar test. For now, I disabled sonar as a requirement but we should fix that. Try again now.

@stv0g stv0g merged commit 48aeffe into sogno-platform:master Mar 27, 2025
@stv0g stv0g deleted the use-python-dicts-for-villas-interface-config branch March 27, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants