Refactor ideal transformer stamping using MNAStampUtils#476
Open
AnasBahr wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anas Bahr <anas.bahr@rwth-aachen.de>
georgii-tishenin
requested changes
May 19, 2026
Contributor
georgii-tishenin
left a comment
There was a problem hiding this comment.
Hi @AnasBahr , thanks for your PR. Some tests in Run pytest over all notebooks check are failing. Apparently, the result of ideal transformer stamping differs from what it was before. Can you investigate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement stampIdealTransformer via MNAStampUtils
Summary
This PR refactors the ideal transformer implementation by introducing and using
stampIdealTransformerfromMNAStampUtilsacross DP, EMT, and SP models.The goal is to remove duplicated manual stamping logic and unify transformer equations in a single reusable utility.
Changes
MNAStampUtils
stampIdealTransformerTemplate<T>DP_Ph1_Transformer
stampIdealTransformerEMT_Ph3_Transformer
SP_Ph1_Transformer
stampIdealTransformerBenefits