Added ROS Noetic Docker File#4
Closed
Srindot wants to merge 1 commit intosoham2560:mainfrom
Srindot:main
Closed
Conversation
Owner
|
This seems to be tackling the same feature as #3 , maybe you guys can coordinate so that less effort is wasted, or you can put a PR targetting his branch or other way around, you decide |
Owner
|
can you also add a test command in the PR description so reviewers can test this easily? or provide a sample .devcontainer conifg |
Collaborator
|
@soham2560 , the issue is fixed! we can close this PR |
Owner
|
okay sounds good, @Srindot if you want to add any feature to the other PR (since I was able to build this branch my own PC), you can open a PR targetting the other one, or if its already merged, directly to main closing for now, thanks for the attempt though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.