CI: Only run semver-checks for lib crates, fix spelling issues#134
Merged
joncinque merged 2 commits intosolana-program:mainfrom Aug 11, 2025
Merged
CI: Only run semver-checks for lib crates, fix spelling issues#134joncinque merged 2 commits intosolana-program:mainfrom
joncinque merged 2 commits intosolana-program:mainfrom
Conversation
#### Problem A publish failed on a proc-macro crate because semver-checks doesn't work on non-lib crates. #### Summary of changes Be a bit smarter, and only run semver-checks if the package has a crate-type that contains the word "lib", which means it'll catch `cdylib`, `rlib`, and `lib`. At the same time, I removed `cdylib` from a few crates that didn't need it, and added a lib target to those that didn't explicitly declare it.
joncinque
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A publish failed on a proc-macro crate because semver-checks doesn't work on non-lib crates.
Summary of changes
Be a bit smarter, and only run semver-checks if the package has a crate-type that contains the word "lib", which means it'll catch
cdylib,rlib, andlib.At the same time, I removed
cdylibfrom a few crates that didn't need it, and added a lib target to those that didn't explicitly declare it.And finally, while adding the crates to the workspace, I had to fix some existing spelling mistakes that weren't caught before.