Conversation
78b268f to
ec6a4b6
Compare
ec6a4b6 to
f24165f
Compare
buffalojoec
reviewed
Oct 1, 2025
Contributor
buffalojoec
left a comment
There was a problem hiding this comment.
Based. Gud fix. Just a few small things.
buffalojoec
approved these changes
Oct 2, 2025
Contributor
buffalojoec
left a comment
There was a problem hiding this comment.
Cool! Thanks for throwing in some extra variants.
Contributor
|
Pinocchio will start using the same program error as the sdk soon, so I would prefer to stick with Edit: mainly because it's a huge hassle to upgrade everything when there's a breaking change to spl-pod, I would avoid it |
Member
Author
|
Oh! If those types are converging, then this is indeed not necessary. Will revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
ListViewis returningProgramErroreverywhere. This makes Pinnochio consumers required to map the error:The primary goal of this change is to enable the direct use of the
?operator in consuming code by returningPodSliceErrorinstead and implementingFromtraits to both program error types. After:Change type
Breaking change. Several returned err types have changed. Will require major version bump. Open to thoughts on how to handle this or if this is the right change in general.