Skip to content

Conversation

@tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Dec 11, 2025

Removes unused param is_legacy as legacy support dropped beginning of year.

Renames some unrelated test mocks but noticed the warnings just now, possibly from type check updates.

Changes the Get-Content call in the Windows smoke tests because they started erroring too. I think it was because of this docstring addition.

@tammy-baylis-swi tammy-baylis-swi changed the title NH-125929 Remove unused param, rename some test mocks NH-125929 Remove unused param, fix and rename some test stuff Dec 11, 2025
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review December 11, 2025 23:45
@tammy-baylis-swi tammy-baylis-swi requested review from a team as code owners December 11, 2025 23:45
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tammy-baylis-swi tammy-baylis-swi merged commit 6ff63b1 into main Dec 12, 2025
64 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-125929-rm-unused-param-rename-mocks branch December 12, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants