Exiting the context manager cleans up files in tmp #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
According to https://docs.python.org/3.11/library/importlib.resources.html, "Exiting the context manager cleans up any temporary file created when the resource was extracted from e.g. a zip file.". With versions of python >3.7, this makes it impossible to return just the string of the path, as it will be sth in
/tmpfolder that would get deleted. Therefore loading the matlab data was moved inside the context manager. The.pathparadigm is also being deprecated as of version 3.11, so I used the files/as_file approach given here https://importlib-resources.readthedocs.io/en/latest/using.htmlThe changes were tested with the 2 smaller scale jupyter examples.
It does seem to work. (And theoretically, the below PR only touches dataloading).