Skip to content

chore: 전체 게시글 조회 시 첫 번째 이미지 url에 해당하는 변수명 변경 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whqtker merged 3 commits into from
Aug 11, 2025
Merged

chore: 전체 게시글 조회 시 첫 번째 이미지 url에 해당하는 변수명 변경 #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e59f2b3
chore: url -> postThumbnailUrl 로 이름 변경
whqtker Aug 9, 2025
a4a4cd8
test: 전체 게시글 조회 시 첫 번째 이미지를 썸네일로 설정하는지 확인하는 테스트 코드 작성
whqtker Aug 9, 2025
0ee3050
test: 하나의 테스트가 두 개의 동작을 검증하지 않고, 하나의 동작만 검증하도록
whqtker Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/example/solidconnection/community/post/dto/PostListResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public record PostListResponse(
ZonedDateTime createdAt,
ZonedDateTime updatedAt,
String postCategory,
String url
String postThumbnailUrl
Comment on lines 15 to +18
Copy link
Contributor

@Gyuhyeok99 Gyuhyeok99 Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 pr과 관련은 없지만 불필요한 Long타입 나중에 한 번 싹 고치는 pr 제가 올리겠습니다!

) {

public static PostListResponse from(Post post) {
Expand Down
40 changes: 40 additions & 0 deletions src/test/java/com/example/solidconnection/community/post/service/PostQueryServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,4 +166,44 @@ void setUp() {
() -> assertThat(redisService.isKeyExists(validateKey)).isTrue()
);
}

@Test
void 게시글_목록_조회시_첫번째_이미지를_썸네일로_반환한다() {
// given
String firstImageUrl = "first-thumbnail-url";
String secondImageUrl = "second-thumbnail-url";
postImageFixture.게시글_이미지(firstImageUrl, post1);
postImageFixture.게시글_이미지(secondImageUrl, post1);

// when
List<PostListResponse> actualResponses = postQueryService.findPostsByCodeAndPostCategory(
BoardCode.FREE.name(),
PostCategory.전체.name()
);

// then
PostListResponse postResponse = actualResponses.stream()
.filter(p -> p.id().equals(post1.getId()))
.findFirst()
.orElseThrow();

assertThat(postResponse.postThumbnailUrl()).isEqualTo(firstImageUrl);
}

@Test
void 게시글에_이미지가_없다면_썸네일로_null을_반환한다() {
// when
List<PostListResponse> actualResponses = postQueryService.findPostsByCodeAndPostCategory(
BoardCode.FREE.name(),
PostCategory.전체.name()
);

// then
PostListResponse postResponse = actualResponses.stream()
.filter(p -> p.id().equals(post3.getId()))
.findFirst()
.orElseThrow();

assertThat(postResponse.postThumbnailUrl()).isNull();
}
}
Loading