Fix consent information #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielbdejong
force-pushed
the
fix-consent-information
branch
from
189ca44 to
14a0b55
Compare
Collaborator
Author
|
Rebased and implemented more cleanly, now that I understand config overrides. I inserted the word 'full' in the phrase 'An application is requesting full access' and the word 'all' in 'Do you trust this application to read and write all your data on your behalf?'. Leaving them out would be downplaying the impact of 'accept', and would make the consent unusable: |
Collaborator
Author
|
No need to merge this before the migration. Would prefer to get some more reviews and merge in January 2025. |
2 tasks
Collaborator
Author
|
After investigating solid/web-access-control-spec#34 (comment) and realising that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better information to the end user, about what the application is getting access to.