Test for POST to non-existing resource #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csarven
approved these changes
Dec 29, 2021
Collaborator
csarven
left a comment
csarven
left a comment
There was a problem hiding this comment.
I think testing a particular content type is equivalent to testing for particular resource types (derived primarily from URI path sending with slash). The difference in this manifest with the manifest in #62 is that the former tests only text/turtle the latter tests both container and non-container.
Would it be meaningful to test other media types of concrete RDF syntaxes or even a random media type?
Collaborator
Author
|
Yes, that makes sense, so I added them. |
edwardsph
reviewed
Jan 7, 2022
Collaborator
edwardsph
left a comment
edwardsph
left a comment
There was a problem hiding this comment.
You haven't sent any body to the server so is it possible that a server will respond with another error e.g. 400 before it checks if the resource exists?
Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
…ature Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
…ature Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
…ature Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
…tainer Test that server protects non-empty container
Test Allow headers for GET and HEAD
Collaborator
Author
|
OK, this should take all comments into account, thanks a lot! |
edwardsph
approved these changes
Jan 10, 2022
protocol/writing-resource/delete-protect-nonempty-container.feature
Outdated
Show resolved
Hide resolved
…ature Co-authored-by: Pete Edwards <edwardsph@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://solidproject.org/TR/protocol#server-post-target-not-found