Skip to content

Conversation

@hzbarcea
Copy link
Member

@hzbarcea hzbarcea commented Mar 4, 2024

Draft agenda for the 03/06 CG meeting

@TallTed
Copy link
Contributor

TallTed commented Mar 5, 2024

(@hzbarcea — Please change PR title from CG Meeging to CG Meeting!)

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating inline comment, so it's more persistent/visible after change suggestions are applied.
Note that #555 still looks alive. Someone coming back to it, to see the latest addition to the bottom of the table, won't necessarily see the top-posted notice that it's been closed with new info being posted at . I suggest adding <strike> or similar to make clear what is no longer valid. https://github.com/orgs/solid/projects/16 requires more thinking, parsing the date column which is no longer in ISO-numerics, figuring out that "status — done" means the meeting has been held... and now, it's even more challenging, because the last dated entry is March 5 (which is now in the past) and shows status "discussed" instead of "done" or at least "scheduled" which seems to make more sense for a date in the past....

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Repeating inline comment here, where it will be more visible and persist after change suggestions are acted on...)

Note that #555 still looks alive. Someone coming back to it, to see the latest addition to the bottom of the table, won't necessarily see the top-posted notice that it's been closed with new info being posted at https://github.com/orgs/solid/projects/16. I suggest adding <strike> or similar to make clear what is no longer valid.

Also note that https://github.com/orgs/solid/projects/16 requires more thinking, parsing the date column which is no longer in ISO-numerics, figuring out that "status — done" means the meeting has been held... and now, it's even more challenging, because the last dated entry is March 5 (which is now in the past) and shows status "discussed" instead of "done" or at least "scheduled" which seem to make more sense for a date in the past....

hzbarcea and others added 10 commits March 12, 2024 10:08
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzbarcea , you can batch the suggestions from the "Files changed" tab ( https://github.com/solid/specification/pull/633/files ) and then make a single commit. That way, only a single (email) notification is sent out where individually accepting the suggestions sends out separate notifications. The former would be less annoying and would be sufficient for something like the minutes I think.

Also... when you finally merge the minutes, please Squash them.

* Call: https://meet.jit.si/solid-cg
* Chat: https://matrix.to/#/#solid_specification:gitter.im
* Repository: https://github.com/solid/specification
* Status: Draft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Status: Draft
* Status: Published

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csarven, I already made this change yesterday: 7dff115. Noted the squashing request.

@TallTed
Copy link
Contributor

TallTed commented Mar 13, 2024

Still titled "Meeging"...

Should be titled "Meeting"...

@michielbdejong michielbdejong changed the title CG Meeging agenda 2024-03-06 CG Meeting agenda 2024-03-06 Mar 19, 2024
@michielbdejong
Copy link
Contributor

I'm seeing:

Merging is blocked
The base branch restricts merging to authorized users.

@VirginiaBalseiro can you see if you can fix that?

@csarven
Copy link
Member

csarven commented Mar 19, 2024

@michielbdejong , you (and other chairs) have access to merge PRs even without approvals. (PRs on this repo require one approval, and there is already one here.) So I'm not sure why you can't squash merge or bypass?

@VirginiaBalseiro
Copy link
Member

@michielbdejong can you check now? I updated one rule that might be related. If not, then I am not sure what is wrong.

@michielbdejong
Copy link
Contributor

That worked apparently, thanks @VirginiaBalseiro!

@michielbdejong michielbdejong merged commit e68bd59 into solid:main Mar 25, 2024
@hzbarcea hzbarcea deleted the meet-0305 branch March 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants