Skip to content

Reorganize vanilla examples#204

Merged
birkskyum merged 4 commits intomainfrom
reorganize-vite-spa-examples
Sep 19, 2025
Merged

Reorganize vanilla examples#204
birkskyum merged 4 commits intomainfrom
reorganize-vite-spa-examples

Conversation

@birkskyum
Copy link
Copy Markdown
Member

@birkskyum birkskyum commented Sep 13, 2025

the vanilla example (those without a meta framework) go into a vanilla folder

Follow up to

The js- vite-spa examples are removed, after agreement on discord
Closes #198

for consistency, rename ts-x to with-x for the vanilla examples, except for ts -> bare and ts-minimal -> `basic

@birkskyum birkskyum mentioned this pull request Sep 13, 2025
@brenelz
Copy link
Copy Markdown

brenelz commented Sep 13, 2025

LGTM. One question I had was the with-solid-router example. Is that a solid start template? Or is that router without start?

@birkskyum
Copy link
Copy Markdown
Member Author

birkskyum commented Sep 13, 2025

It's the router without start, just spa routing on the client

@birkskyum
Copy link
Copy Markdown
Member Author

birkskyum commented Sep 14, 2025

I think when this merges the cli can be updated, but this will likely break the references from the cli, so have to happen coordinated - cc @Tommypop2

@atilafassina
Copy link
Copy Markdown
Member

I think when this merges the cli can be updated, but this will likely break the references from the cli, so have to happen coordinated - cc @Tommypop2

yeah, I was thinking that too.

The change looks good, but this needs to come together with a CLI release.

Alternatively, we could merge a fallback in the CLI code so both paths work - or even duplicate the templates here and then make another PR deleting once the CLI gets a new release to the updated path.

@birkskyum
Copy link
Copy Markdown
Member Author

birkskyum commented Sep 15, 2025

We can prepare a PR for the cli, so that it can be merged/updated in sync

@birkskyum birkskyum changed the title Reorganize vite spa examples Reorganize vanilla examples Sep 19, 2025
@birkskyum birkskyum merged commit 73b2125 into main Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove JS templates

3 participants