-
Notifications
You must be signed in to change notification settings - Fork 94
Open
Description
What does "safe" mean? Any of the following:
- revert if an ERC20 function returns
falsebut does not itself revert - use
increaseAllowanceanddecreaseAllowanceinstead ofapprove - workaround nonstandard alternatives to
increaseAllowanceanddecreaseAllowance - workaround tokens that don't even conform to ERC20 and don't return a
boolat all
#239 and #245 were an attempt to make the library consistent with the first point above, because it's the only point that is truly the responsibility of the contract and makes sense within the context of a single transaction. But consistency comes at the cost of not pandering to nonstandard tokens.
Metadata
Metadata
Assignees
Labels
No labels