Always set a line item's currency to order currency#1007
Merged
gmacdougall merged 1 commit intomasterfrom Mar 31, 2016
unknown repository
Merged
Always set a line item's currency to order currency#1007gmacdougall merged 1 commit intomasterfrom unknown repository
gmacdougall merged 1 commit intomasterfrom
unknown repository
Conversation
Member
|
Looks good to me. Thanks for working on this. 👍 |
Member
|
👍 Looks good to me. |
Member
There was a problem hiding this comment.
Maybe not everyone intended to change the line item currency and something else change it. Without knowing that, the current warning could be misleading.
Why not just: "The line items currency is different from it's order currency. This behavior is not supported anymore and will be deleted soon."?
Member
|
👍 otherwise |
Before, a line item could under certain circumstances be assigned the store's default currency, rather than its order's currency. With this commit, we're making sure Solidus does not do that, as well as deprecating setting the currency manually to something other than the order's currency.
Contributor
Author
|
Thanks @tvdeyen - I took your suggested wording for the deprecation message. |
Member
|
👍 |
Member
|
👍 again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, a line item could under certain circumstances be assigned
the store's default currency, rather than its order's currency.
With this commit, we're making sure Solidus does not do that, as
well as deprecating setting the currency manually to something
other than the order's currency.