Add inverse_of to promotion actions and rules#1420
Merged
jordan-brough merged 1 commit intosolidusio:masterfrom Sep 17, 2016
Merged
Add inverse_of to promotion actions and rules#1420jordan-brough merged 1 commit intosolidusio:masterfrom
jordan-brough merged 1 commit intosolidusio:masterfrom
Conversation
This isn't happening automatically.
Without this patch:
>> p = Spree::Promotion.create!(name: 'foo')
>> p.promotion_rules << Spree::Promotion::Rules::FirstOrder.new
>> p.promotion_actions << Spree::Promotion::Actions::FreeShipping.new
>> p.object_id == p.promotion_rules.to_a.first.promotion.object_id
=> false
>> p.object_id == p.promotion_actions.to_a.first.promotion.object_id
=> false
With this patch those queries return true.
Contributor
|
👍 I'd guess that rails doesn't understand our |
Contributor
Author
|
FYI I added an issue to look into things further: #1452 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't happening automatically.
Without this patch:
With this patch those queries return true.
It seems likely that there are a lot of other places where we should add this. Or else figure out why it's not happening automatically.