Merged
Conversation
tvdeyen
approved these changes
Oct 19, 2018
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
I ❤️ the Netlify preview. Working perfectly. Thanks.
Member
Author
|
I'm actually seeing a UI change in the header in desktop: Before:
After:
I'll try to take a look soo, I have no idea what could be, but I ❤️Netlify previews even more. 🙂 |
Member
Author
|
Ok I think it's related to this issue on Twitter Bootstrap: twbs/bootstrap#26820 |
kennyadsl
force-pushed
the
guides-improvements
branch
from
6300498 to
72d309f
Compare
Remove broken links, add Yarn and remove Gulp, which does not seem to be used
This is needed for a security issue: CVE-2017-16028 Vulnerable versions: < 3.0.0 Patched version: 3.0.0 https://nvd.nist.gov/vuln/detail/CVE-2017-16028
In latest Twitter Bootstrap versions form-control height is no more auto and this change is needed to make our search bar work properly, see: twbs/bootstrap#26820
kennyadsl
force-pushed
the
guides-improvements
branch
from
72d309f to
bc25ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches Guides package manager to yarn, improves the README and updates
randomatic, a vulnerable package (that is not dangerous since we only use that in development).