Fix Sprockets 4 support for extensions#3373
Fix Sprockets 4 support for extensions#3373kennyadsl merged 1 commit intosolidusio:masterfrom aldesantis:aldesantis/bugfix/sprockets-4
Conversation
|
We'll need this PR to fix all extensions specs, but if #3379 will be merged only. Otherwise, we can close this PR and backport the Sprockets 3 lock to all the supported Solidus versions. |
|
I'll close this in the meantime since we've locked Solidus to Sprockets 3. If rails/sprockets-rails#446 is merged, Solidus may become compatible with Sprockets 4, in which case I'll reopen it. |
Sprockets 4 uses manifest files[1], and the default manifest.js links `app/assets/images`. To prevent it from crashing due to the directory not being present, the easiest solution is to create an empty `app/assets/images` directory. [1]: https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs
|
Reopening this, since:
Sorry about the confusion! Note that this will also need to be backported to all currently supported Solidus version branches. We won't need to release new versions, since it's a dev-only change and extensions use branches rather than tags. |
jacobherrington
left a comment
There was a problem hiding this comment.
I am happy with merging this, but I'd like to see a comment explaining why we need to do this or at least linking back to this PR.
Description
This fixes an issue with extension tests failing due to Sprockets 4 requiring an
app/assets/imagesdirectory to be present.Checklist: