Skip to content

Add support for Sprockets v4 to the DummyApp #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elia merged 2 commits into from
Jan 9, 2024
Merged

Add support for Sprockets v4 to the DummyApp #3379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a35ea5
Add a DummyApp sprockets 4 configuration manifest
kennyadsl Oct 11, 2019
9c4057d
Lock rack to be less than 3
elia Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ else
end
# rubocop:enable Bundler/DuplicatedGem

# Temporarily locking sprockets to v3.x
# see https://github.com/solidusio/solidus/issues/3374
# and https://github.com/rails/sprockets-rails/issues/369
gem 'sprockets', '~> 3'

gem 'pry'
gem 'launchy', require: false

Expand All @@ -31,6 +26,7 @@ gem 'rspec-rails', '~> 6.0.3', require: false
gem 'rspec-retry', '~> 0.6.2', require: false
gem 'simplecov', require: false
gem 'simplecov-cobertura', require: false
gem 'rack', '< 3', require: false
gem 'rake', require: false, groups: [:lint, :release]
gem 'rails-controller-testing', require: false
gem 'puma', '< 6', require: false
Expand Down
5 changes: 4 additions & 1 deletion core/lib/spree/testing_support/dummy_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ module ApplicationHelper
module DummyApp
def self.setup(gem_root:, lib_name:, auto_migrate: true)
ENV["LIB_NAME"] = lib_name
DummyApp::Application.config.root = File.join(gem_root, 'spec', 'dummy')
root = Pathname(gem_root).join('spec/dummy')
root.join("app/assets/config").mkpath
root.join("app/assets/config/manifest.js").write("// Intentionally empty\n")

DummyApp::Application.config.root = root
DummyApp::Application.initialize! unless DummyApp::Application.initialized?

if auto_migrate
Expand Down