Move currently_valid_prices to a method#4073
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom May 28, 2021
Merged
Conversation
kennyadsl
reviewed
May 21, 2021
Having `currently_valid_prices` as an association between `Variant` and `Price` made it a source of inconsistencies with the undecorated `prices` association: ``` Spree::Variant.new.tap do |v| v.currently_valid_prices << Spree::Price.new end.prices.any? # => false ```
waiting-for-dev
force-pushed
the
waiting-for-dev/move_currently_valid_to_a_price
branch
from
3730274 to
515fbe5
Compare
gmacdougall
approved these changes
May 26, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
currently_valid_pricesas an association betweenVariantandPricemade it a source of inconsistencies with the undecoratedpricesassociation:Note: Extraction from #3994
Checklist: