Rename currently_valid to prioritized_for_default#4109
Closed
waiting-for-dev wants to merge 1 commit intosolidusio:masterfrom
Closed
Rename currently_valid to prioritized_for_default#4109waiting-for-dev wants to merge 1 commit intosolidusio:masterfrom
waiting-for-dev wants to merge 1 commit intosolidusio:masterfrom
Conversation
It conveys better what it's doing, as the query only consists of `ORDER` clauses and no record is filtered out.
kennyadsl
requested changes
Jun 21, 2021
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Nice, but I think we need some deprecations here.
| # Returns `#prices` prioritized for being considered as default price | ||
| # | ||
| # @return [ActiveRecord::Relation<Spree::Price>] | ||
| def currently_valid_prices |
Member
There was a problem hiding this comment.
I think we should deprecate this method instead of removing it.
| validates :currency, inclusion: { in: ::Money::Currency.all.map(&:iso_code), message: :invalid_code } | ||
| validates :country, presence: true, unless: -> { for_any_country? } | ||
|
|
||
| scope :currently_valid, -> { order(Arel.sql("country_iso IS NULL")).order(updated_at: :DESC, id: :DESC) } |
Member
There was a problem hiding this comment.
Let's deprecate this as well!
Contributor
Author
|
We're closing it as we'll be revisiting this stuff in the context of services objects. |
waiting-for-dev
deleted the
waiting-for-dev/rename_currently_valid_to_priorititzed_for_default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It conveys better what it's doing, as the query only consists of
ORDERclauses and no record is filtered out.
Extracted from #3994
Checklist: