Add inverse_of to the payments association.#414
Closed
Senjai wants to merge 1 commit intosolidusio:masterfrom
Closed
Add inverse_of to the payments association.#414Senjai wants to merge 1 commit intosolidusio:masterfrom
Senjai wants to merge 1 commit intosolidusio:masterfrom
Conversation
This is an investigative commit, as the regression for the original issue now passes with the inverse of, though it appears to cause other issues.
Senjai
force-pushed
the
payment_inverse_of
branch
from
1402a59 to
8a76d44
Compare
Contributor
There was a problem hiding this comment.
Maybe delete the comment as well? lol
Contributor
Author
There was a problem hiding this comment.
I dont think we should, the test that is in this context is the regression for the issue mentioned in the comment.
|
@Senjai just checking in on how the investigation is going |
Contributor
|
This fails because the list of changed attributes is not cleared by update columns, causing that one test to fail. #425 will fix this. |
Contributor
Author
|
Closing in favor of #425 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an investigative commit, as the regression for the original
issue now passes with the inverse of, though it appears to cause other
issues.
We should be able to use this now, PR'd for specs and discussion cc @jhawthorn