Bugfix: Changing Default Addresses#4332
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom Apr 19, 2022
Merged
Conversation
Solidus' immutable addresses allow "changing" an address by passing its ID to the `save_in_address_book` method. If one does that with an address that was marked as default shipping or billing of the user, the old address would be archived, and the new address would not become the user's default address. This change addresses that by handling that situation for both default billing and default shipping addresses.
jarednorman
approved these changes
Apr 12, 2022
jarednorman
approved these changes
Apr 12, 2022
Member
|
Thanks @mamhoff! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solidus' immutable addresses allow "changing" an address by passing its
ID to the
save_in_address_bookmethod. If one does that with anaddress that was marked as default shipping or billing of the user, the
old address would be archived, and the new address would not become the
user's default address. This change addresses that by handling that
situation for both default billing and default shipping addresses.
Prerequisite for #3852
Checklist: