Remove the devise-specific fields from spree_users#4440
Closed
elia wants to merge 1 commit intosolidusio:mainfrom
Closed
Remove the devise-specific fields from spree_users#4440elia wants to merge 1 commit intosolidusio:mainfrom
elia wants to merge 1 commit intosolidusio:mainfrom
Conversation
Contributor
|
@elia, I think that if you rebase from master CI will be green 🪄 |
2db1253 to
531b5f7
Compare
Contributor
|
Hey, @elia, is it ready for review? 🙂 |
531b5f7 to
579dce6
Compare
Contributor
|
@elia did this ever make it over the finish line? |
Let solidus_auth_devise add and maintain the fields it needs.
579dce6 to
73f2c4c
Compare
Member
Author
|
@fthobe no, it needs those columns to be added individually in solidus_auth_devise first, not a difficult change if the CI is in good shape |
Contributor
|
You were quicker |
Member
Author
|
No, it wouldn't change a thing, we remove columns here where they don't belong, but it won't pass until auth devise adds support for them if they're missing. |
This was referenced Apr 17, 2026
Member
|
Closing in favour of #6442. Additionally, the work is now tracked on the solidus_auth_devise repo here: solidusio/solidus_auth_devise#274. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let solidus_auth_devise add and maintain the fields it needs.
Extracted from #3923
Description
Checklist: