Improve variant spec coverage#4642
Merged
waiting-for-dev merged 7 commits intosolidusio:masterfrom Sep 27, 2022
Merged
Conversation
Also fixes the type of the default argument to empty array as the documentation says.
github-actions
Bot
added
the
changelog:solidus_core
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #4642 +/- ##
==========================================
+ Coverage 85.58% 85.63% +0.04%
==========================================
Files 570 570
Lines 14678 14678
==========================================
+ Hits 12562 12569 +7
+ Misses 2116 2109 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kennyadsl
reviewed
Sep 26, 2022
mamhoff
force-pushed
the
improve-variant-spec-coverage
branch
from
14c0b15 to
b35432e
Compare
jarednorman
approved these changes
Sep 26, 2022
waiting-for-dev
approved these changes
Sep 27, 2022
Contributor
waiting-for-dev
left a comment
waiting-for-dev
left a comment
There was a problem hiding this comment.
Minor suggestion to go the extra mile 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds some specs for a few instance methods on Spree::Variant. No functional changes.
Checklist
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the readme to account for my changes.