Skip to content

Do not require 'mail'#4740

Merged
kennyadsl merged 1 commit intosolidusio:masterfrom
tvdeyen:remove-mail-require
Dec 19, 2022
Merged

Do not require 'mail'#4740
kennyadsl merged 1 commit intosolidusio:masterfrom
tvdeyen:remove-mail-require

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Nov 23, 2022

Summary

This was added a long time ago and is actually not necessary anymore. If a shop depends on mail then through actionmailer.

Refs #4734

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

This was added a long time ago and is actually not necessary
anymore. If a shop depends on mail then through actionmailer.

Refs solidusio#4734
@github-actions github-actions Bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 23, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2022

Codecov Report

Merging #4740 (4ff8593) into master (d582f54) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4740      +/-   ##
==========================================
- Coverage   86.14%   86.13%   -0.01%     
==========================================
  Files         578      578              
  Lines       14654    14653       -1     
==========================================
- Hits        12623    12622       -1     
  Misses       2031     2031              
Impacted Files Coverage Δ
core/lib/spree/core.rb 96.51% <ø> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@waiting-for-dev waiting-for-dev added the type:bug Error, flaw or fault label Nov 28, 2022
Copy link
Copy Markdown
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvdeyen!

@kennyadsl kennyadsl merged commit f3502d3 into solidusio:master Dec 19, 2022
@github-actions
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
v3.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants