Skip to content

Misc cleanup of all text files#4837

Closed
basicfeatures wants to merge 1 commit intosolidusio:masterfrom
basicfeatures:master
Closed

Misc cleanup of all text files#4837
basicfeatures wants to merge 1 commit intosolidusio:masterfrom
basicfeatures:master

Conversation

@basicfeatures
Copy link
Copy Markdown

@basicfeatures basicfeatures commented Jan 5, 2023

  • Remove CR+LF (^M)
  • Remove trailing whitespace
  • Compress two or more consecutive blank lines
  • Ensure newline at EOF

https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file

Misc cleanup of all text files
091ac10 
- Remove CR+LF (^M)
- Remove trailing whitespace
- Compress two or more consecutive blank lines
- Ensure newline at EOF

https://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
@basicfeatures basicfeatures requested a review from a team as a code owner January 5, 2023 14:00
@github-actions github-actions Bot added changelog:repository Changes to the repository not within any gem changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Jan 5, 2023
jarednorman
jarednorman previously approved these changes Jan 5, 2023
View reviewed changes
kennyadsl
kennyadsl reviewed Jan 5, 2023
View reviewed changes
Comment thread dev_tools/lib/solidus/release_drafter.rb
def full_changelog(current_diff_source_tag, candidate_tag)
<<~TXT


Copy link
Copy Markdown
Member

@kennyadsl kennyadsl Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra space is intentional, see https://app.circleci.com/pipelines/github/solidusio/solidus/3952/workflows/a82c4d50-c4ee-426b-92b4-5cccee0ad4fe/jobs/36006. We can probably get rid of it, but the specs should reflect the change, cc @waiting-for-dev.

Copy link
Copy Markdown
Member

@jarednorman jarednorman Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good catch.

@kennyadsl kennyadsl removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem labels Jan 6, 2023
waiting-for-dev
waiting-for-dev suggested changes Jan 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@waiting-for-dev waiting-for-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean-up ❤️

Let's revert the changes in the dev_tools directory out for now, as all blank lines were intentionally there.

@jarednorman jarednorman dismissed their stale review January 9, 2023 16:54

Missed things.

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Jan 31, 2023
@kennyadsl
Copy link
Copy Markdown
Member

kennyadsl commented Jan 31, 2023

Hello @basicfeatures! Do you plan to take a look at the suggestions made by @waiting-for-dev to complete this PR? Thanks in advance.

jarednorman
jarednorman reviewed Jan 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make sure that this commit gets added to the commits that are ignored in blames.

@waiting-for-dev
Copy link
Copy Markdown
Contributor

waiting-for-dev commented Feb 1, 2023

We should also make sure that this commit gets added to the commits that are ignored in blames.

See #4741 for context

@basicfeatures basicfeatures closed this by deleting the head repository Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennyadsl kennyadsl kennyadsl left review comments

@jarednorman jarednorman jarednorman left review comments

+1 more reviewer

@waiting-for-dev waiting-for-dev waiting-for-dev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog:repository Changes to the repository not within any gem type:enhancement Proposed or newly added feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@basicfeatures @kennyadsl @waiting-for-dev @jarednorman