ERB fixes for the backend (🐛+💅)#4891
Merged
kennyadsl merged 11 commits intosolidusio:masterfrom Feb 1, 2023
Merged
Conversation
github-actions
Bot
added
changelog:solidus_backend
adammathys
approved these changes
Jan 31, 2023
kennyadsl
approved these changes
Jan 31, 2023
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Thanks Elia! I hope no deface override out there is targeting a wrong html/erb tag! 😁
waiting-for-dev
approved these changes
Feb 1, 2023
Contributor
waiting-for-dev
left a comment
waiting-for-dev
left a comment
There was a problem hiding this comment.
Thanks! Do we want to ignore some of those commits on git-blame? See #4741
Member
Author
|
@waiting-for-dev yes! I'll provide a PR once it's merged and the commit refs are stable 👍👍👍 |
As reported by erb_lint it may confuse parsers and doesn't add any value.
And add a final newline where it was missing.
elia
force-pushed
the
elia/admin-erb-fixes
branch
from
1b6d41d to
3e66a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After randomly noticing a badly closed HTML tag I ran a couple of linters on the entire body of ERB files within
backend/app/views. The two linters are erb-formatter and erb_lint.I only used
autocorrectsparingly and avoided reformatting everything, only some of the changes are straight up bugfixes, the most obvious exception being the extra newlines removed.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):