Skip to content

Remove default tax zone validation #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mamhoff wants to merge 1 commit into from
Closed

Remove default tax zone validation #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/app/models/spree/tax_rate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,3 @@
module Spree
class DefaultTaxZoneValidator < ActiveModel::Validator
def validate(record)
if record.included_in_price
record.errors.add(:included_in_price, Spree.t(:included_price_validation)) unless Zone.default_tax
end
end
end
end

module Spree
class TaxRate < Spree::Base
acts_as_paranoid
Expand All @@ -25,7 +15,6 @@ class TaxRate < Spree::Base

validates :amount, presence: true, numericality: true
validates :tax_category_id, presence: true
validates_with DefaultTaxZoneValidator

scope :by_zone, ->(zone) { where(zone_id: zone) }

Expand Down