Add Zone#states and Zone#countries associations#529
Conversation
Contributor
|
👍 from me. I don't like zones or members or how we handle any of that, but I don't have a better plan than what we have now and am okay supporting those associations on Zones. |
Merged
Contributor
Author
|
Will do. |
Contributor
Author
|
Uh, wrong one. sorry. |
Contributor
There was a problem hiding this comment.
Could this be expect(zone.countries.to_a).to eq([country])? Just to make the expectation a little stricter?
Contributor
|
Nice update, thanks. 👍 regardless of my one question in the spec. |
As requested in #529 (comment)
Contributor
Author
|
The build failure is due to some CSS not being found. I'm reasonably sure it's nothing to do with stricter expecations on zone associations :) |
cbrunsdon
added a commit
that referenced
this pull request
Nov 24, 2015
Add Zone#states and Zone#countries associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also adds a
:with_countryfactory to ease writing tests for taxation.