Enhance product model with variants_option_values ransacker#5395
Merged
elia merged 1 commit intosolidusio:mainfrom Sep 29, 2023
Merged
Conversation
github-actions
Bot
added
the
changelog:solidus_core
rainerdema
force-pushed
the
rainerd/feature/product-variant-option-values-ransacker
branch
3 times, most recently
from
a81706a to
408a8b9
Compare
3 tasks
elia
reviewed
Sep 28, 2023
rainerdema
force-pushed
the
rainerd/feature/product-variant-option-values-ransacker
branch
2 times, most recently
from
f9e1ddf to
a223dd8
Compare
rainerdema
force-pushed
the
rainerd/feature/product-variant-option-values-ransacker
branch
from
a223dd8 to
a020947
Compare
Introduce a ransacker `variants_option_values` on Spree::Product. This ransacker enables dynamic filtering combined with ransack on product variants option values. For now, this attribute is geared towards usage in the admin interface. https://activerecord-hackery.github.io/ransack/going-further/ransackers/
rainerdema
force-pushed
the
rainerd/feature/product-variant-option-values-ransacker
branch
from
a020947 to
0c66e14
Compare
elia
approved these changes
Sep 29, 2023
elia
deleted the
rainerd/feature/product-variant-option-values-ransacker
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new ransacker,
variants_option_values, to theSpree::Productmodel.The primary purpose of this ransacker is to enhance filtering capabilities within the admin interface.
It facilitates combinate option type filtering with ransack, allowing for more refined searches based on variant option values.
variants_option_valuesto enable searching based on product variants' option values.allowed_ransackable_attributesto includevariants_option_values.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: