Skip to content

[4.1] Update pinned chrome version#5463

Merged
tvdeyen merged 1 commit intov4.1from
backport/v4.1/pr-5459
Oct 27, 2023
Merged

[4.1] Update pinned chrome version#5463
tvdeyen merged 1 commit intov4.1from
backport/v4.1/pr-5459

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Oct 27, 2023

Backport

This will backport the following commits from main to v4.1:

Questions ?

Please refer to the Backport tool documentation

The current version does not exist anymore. We need to
update it.

(cherry picked from commit 0605c98)
@tvdeyen tvdeyen requested a review from a team as a code owner October 27, 2023 08:18
@github-actions github-actions Bot added the changelog:repository Changes to the repository not within any gem label Oct 27, 2023
@tvdeyen tvdeyen changed the title Update pinned chrome version [4.1] Update pinned chrome version Oct 27, 2023
@tvdeyen
Copy link
Copy Markdown
Member Author

tvdeyen commented Oct 27, 2023

The spec only fails because we cannot install Solidus 4.2 in a Solidus 4.1 branch. Not sure why we test this in all branches. Does not make sense to me. Merging anyhow, because currently all backport PRs fail becaus of this.

Also, not sure what the issue with rubocop is. The same branch passes locally. It only fails on CI. Maybe caching issues? Since this change has not touched and Ruby code we can simply ignore this.

@tvdeyen tvdeyen merged commit b6215a2 into v4.1 Oct 27, 2023
@tvdeyen tvdeyen deleted the backport/v4.1/pr-5459 branch October 27, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant