[4.1] Use ActiveRecord's .find_each instead of .each whenever possible#5484
Merged
tvdeyen merged 2 commits intosolidusio:v4.1from Nov 2, 2023
Merged
[4.1] Use ActiveRecord's .find_each instead of .each whenever possible#5484tvdeyen merged 2 commits intosolidusio:v4.1from
.find_each instead of .each whenever possible#5484tvdeyen merged 2 commits intosolidusio:v4.1from
Conversation
tvdeyen
added
changelog:solidus_api
3 tasks
elia
approved these changes
Nov 2, 2023
Member
elia
left a comment
elia
left a comment
There was a problem hiding this comment.
👍👍👍
pending the installer specs, tbh I'm not sure why the rackup executable is causing trouble, maybe there's a -y or -f that we can add to overcome the problem.
Member
Author
Member
|
@tvdeyen I'm down with backporting it, I think the backport labels will trigger the gh action even after merge 👍 |
Member
Author
|
That's good to know. @kennyadsl agree? |
Member
|
Works for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #5380 for v4.1