[ADMIN] Fix flash messages coloring#5681
Merged
spaghetticode merged 1 commit intosolidusio:mainfrom Mar 7, 2024
Merged
Conversation
Previously, all flash messages were showing with the same (black) background. Internally, the flash object converts and stores keys as strings [1]. [1] https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/middleware/flash.rb#L163
spaghetticode
force-pushed
the
spaghetticode/fix-admin-flash
branch
from
58f7bf2 to
991a179
Compare
kennyadsl
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, all flash messages were showing with the same (black) background. Internally, the flash object converts and stores keys as strings.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: