Skip to content

Fix JS locale data for release of Money 6.19#5683

Merged
spaghetticode merged 1 commit intosolidusio:mainfrom
mamhoff:fix-money-6.19
Mar 7, 2024
Merged

Fix JS locale data for release of Money 6.19#5683
spaghetticode merged 1 commit intosolidusio:mainfrom
mamhoff:fix-money-6.19

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Mar 6, 2024

Summary

The money gem in its latest iteration added a space between value and unit of the Swiss Franc. Our heuristic in _js_locale_data.html.erb can't deal with that, so we add a third branch to it: If the money gem has a format wish, we'll respect it, but replace its abbreviations with the one the accounting.js library prefers.

Cf https://github.com/RubyMoney/money/blob/main/CHANGELOG.md#6190

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The money gem in its latest iteration added a space between value and
unit of the Swiss Franc. Our heuristic in `_js_locale_data.html.erb`
can't deal with that, so we add a third branch to it: If the money gem
has a format wish, we'll respect it, but replace its abbreviations with
the one the `accounting.js` library prefers.
@mamhoff mamhoff requested a review from a team as a code owner March 6, 2024 21:59
@github-actions github-actions Bot added the changelog:solidus_backend Changes to the solidus_backend gem label Mar 6, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (d5dd8b6) to head (f19e6fc).
Report is 1033 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5683   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         699      699           
  Lines       16607    16607           
=======================================
  Hits        14760    14760           
  Misses       1847     1847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mamhoff ❤️

@spaghetticode spaghetticode merged commit 885a453 into solidusio:main Mar 7, 2024
@spaghetticode spaghetticode added the backport-v4.3 Backport this pull-request to v4.3 label Mar 11, 2024
@github-actions
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen tvdeyen added backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Dec 2, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (f19e6fc) is empty. It looks like the commit was already backported in #5690

Manual backport

To create the backport manually run:

backport --pr 5683

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (f19e6fc) is empty. It looks like the commit was already backported in #5690

Manual backport

To create the backport manually run:

backport --pr 5683

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2024

💔 Some backports could not be created

Status Branch Result
v4.0
v4.1
v4.2
v4.3 Cherrypick failed because the selected commit (f19e6fc) is empty. It looks like the commit was already backported in #5690

Manual backport

To create the backport manually run:

backport --pr 5683

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 changelog:solidus_backend Changes to the solidus_backend gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants