Skip to content

Show the page action for creating a new shipping method#5719

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:feature/solidus_admin/add-new-shipping-method-page-action
Apr 12, 2024
Merged

Show the page action for creating a new shipping method#5719
tvdeyen merged 1 commit intosolidusio:mainfrom
SuperGoodSoft:feature/solidus_admin/add-new-shipping-method-page-action

Conversation

@forkata
Copy link
Copy Markdown
Contributor

@forkata forkata commented Apr 11, 2024

Summary

It would be helpful to be able to add shipping methods in the new admin, even though the new action views are not migrated yet. This change renames the actions method to page_actions to get that.

Screenshot
Screenshot 2024-04-11 at 3 34 12 PM

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

It would be helpful to be able to add shipping methods in the new admin,
even though the new views are not migrated yet. This change renames the
actions method to page_actions to get that.

Co-authored-by: Harmony Bouvier <harmony@super.gd>
@forkata forkata requested a review from a team as a code owner April 11, 2024 22:34
Copy link
Copy Markdown
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks Chris!

@tvdeyen
Copy link
Copy Markdown
Member

tvdeyen commented Apr 12, 2024

CI Failure fixed in #5721

@tvdeyen tvdeyen merged commit 8a5b257 into solidusio:main Apr 12, 2024
@harmonymjb harmonymjb deleted the feature/solidus_admin/add-new-shipping-method-page-action branch April 16, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants