CI: Update ESLint Config

[loicginoux]

Summary

the es lint upgrade changed the way eslint config file is declared. we had to rename and migrate config options to the new configuration system

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[tvdeyen]

@loicginoux nice! Thanks. I just disabled the new config in #5721 but this is probably better because its future proof :)

[tvdeyen]

Nice, but we should not pretend to be a npm package. We just use the package.json for dependency management for ESLint (and maybe other JS tools), but never will publish Solidus as NPM package 😆

[tvdeyen]

It seems there is more involved. Maybe we merge #5721 first and then continue the work here?

[loicginoux]

I'll continue exploring the CI environment, I guess it's just a missing npm install in CI env.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (a2e1519) to head (2f7a74e).
Report is 11 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5722   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         702      702           
  Lines       16698    16698           
=======================================
  Hits        14852    14852           
  Misses       1846     1846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[loicginoux]

It looks good now @tvdeyen, I can squash commits if requested.

[tvdeyen]

I merged #5721 now. I am not sure we want this change as this means we need to maintain a package.json with its dependencies and a custom eslint config file. Before we where just using npx and the default eslint config.

addressed

[loicginoux]

I understand, fair point... I leave you close the issue if you think this problem is solved.

[tvdeyen]

@solidusio/core-team wdyt?

[kennyadsl]

I like the completeness of this solution, but considering that ESlint is a very very small part of this project, I'd avoid any maintenance effort for the plugin. I'd probably rather remove it and try to use something else. I think that for now the solution @tvdeyen proposed is enough, but I'd keep this as a reference if we want to change idea later.

Thanks, @loicginoux and @tvdeyen !

[tvdeyen]

Thanks for working on this @loicginoux but i agree with @kennyadsl and am closing this for now. Again, thanks for investing and contributing.