[v4.2] Restrict sqlite3 gem to '~> 1.3', like ActiveRecord#5746
Merged
[v4.2] Restrict sqlite3 gem to '~> 1.3', like ActiveRecord#5746
Conversation
github-actions
Bot
added
the
changelog:repository
github-actions
Bot
force-pushed
the
backport/v4.2/pr-5727
branch
2 times, most recently
from
225f261 to
bb5cc24
Compare
github-actions
Bot
force-pushed
the
backport/v4.2/pr-5727
branch
from
bb5cc24 to
7db9422
Compare
tvdeyen
changed the title
tvdeyen
approved these changes
May 8, 2024
They just released sqlite3 2.0.0, but ActiveRecord's sqlite3 adapter doesn't know about this yet, leading to conflicting sqlite3 gems in specs. This is probably a temporary fix until ActiveRecord learns the news. (cherry picked from commit 4319e17)
The task itself is fine, as it inherits from Rails' app generator, which has the sqlite3 restriction: https://github.com/rails/rails/blob/main/railties/lib/rails/generators/database.rb#L19. (cherry picked from commit e85fd4c)
tvdeyen
force-pushed
the
backport/v4.2/pr-5727
branch
from
7db9422 to
e89da30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.2:Questions ?
Please refer to the Backport tool documentation