Skip to content

Limit supported rails version to before 7.2#5832

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
ugifractal:rails-version-requirement
Aug 27, 2024
Merged

Limit supported rails version to before 7.2#5832
tvdeyen merged 1 commit intosolidusio:mainfrom
ugifractal:rails-version-requirement

Conversation

@ugifractal
Copy link
Copy Markdown
Contributor

Summary

This PR aimed to limit rails version to below 7.2 for improving error message during bundle install

@ugifractal ugifractal requested a review from a team as a code owner August 19, 2024 23:39
@github-actions github-actions Bot added the changelog:repository Changes to the repository not within any gem label Aug 19, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (b766363) to head (70f35bd).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5832   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files         739      739           
  Lines       17246    17246           
=======================================
  Hits        15363    15363           
  Misses       1883     1883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl kennyadsl added the backport-v4.3 Backport this pull-request to v4.3 label Aug 20, 2024
Copy link
Copy Markdown
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added the backport-v4.3 so this change is automatically backported to the latest version, which supports Rails 7.1.

@tvdeyen tvdeyen merged commit c9cabba into solidusio:main Aug 27, 2024
@github-actions
Copy link
Copy Markdown

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.3 Backport this pull-request to v4.3 changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants