Skip to content

[v4.3] Lock solidus_core.gemspec to ransack '< 4.2' #5839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 2 commits into from
Aug 27, 2024
Merged

[v4.3] Lock solidus_core.gemspec to ransack '< 4.2' #5839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c01a42
Fix failing solidus_admin thumbnail spec
MadelineCollier Aug 8, 2024
976175a
Lock solidus_core.gemspec to ransack '< 4.2'
MadelineCollier Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/spec/components/previews/solidus_admin/ui/thumbnail/component_preview/overview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
<div class="flex gap-4">
<% product = Spree::Product.new(name: "A good product") %>
<% attachment = Object.new.tap { def _1.url(*) "https://placekitten.com/280/200"; end } %>
<% image = Spree::Image.new.tap { _1.define_singleton_method(:attachment) { attachment } } %>
<% image = Spree::Image.new.tap { |img| img.define_singleton_method(:attachment) { attachment } } %>
<% [
Spree::PromotionAction.new,
Spree::UnitCancel.new,
Expand Down
4 changes: 3 additions & 1 deletion core/solidus_core.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ Gem::Specification.new do |s|
s.add_dependency 'monetize', '~> 1.8'
s.add_dependency 'kt-paperclip', ['>= 6.3', '< 8']
s.add_dependency 'psych', ['>= 4.0.1', '< 6.0']
s.add_dependency 'ransack', '~> 4.0'
# @note ransack 4.2 contains a bug which has not yet been addressed.
# @see https://github.com/activerecord-hackery/ransack/pull/1468
s.add_dependency 'ransack', ['~> 4.0', '< 4.2']
s.add_dependency 'sprockets-rails'
s.add_dependency 'state_machines-activerecord', '~> 0.6'
s.add_dependency 'omnes', '~> 0.2.2'
Expand Down